Remove non-existent --eval-provider and --eval-base-url from generate docs#17
Merged
evalstate merged 1 commit intohuggingface:mainfrom Feb 9, 2026
Conversation
… docs These options were removed from the generate command but the documentation still referenced them, causing user errors. Changes: - Remove --eval-provider and --eval-base-url from README options list - Update example to use --no-eval instead of non-existent options - Fix CLI help docstring to match actual available options
Collaborator
|
Thanks for catching this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes documentation that references options that no longer exist in the
generatecommand.The
--eval-providerand--eval-base-urloptions were removed from thegeneratecommand in commit 542b3af, but the documentation was not updated.Problem
Users following the documentation get errors:
Changes
--eval-providerand--eval-base-urlfrom README options list--no-evalinstead of non-existent optionsVerification
upskill generate --helpnow shows only valid optionsNote: For local model evaluation, users can use
upskill evalwith--base-urlafter generating with--no-eval.